Addendum to use per-puzzle cost to estimate DEDUP savings #19816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmineKhaldi
added
the
Changed
github-actions
bot
added
the
merge_conflict
AmineKhaldi
force-pushed
the
addendum_to_19811
branch
from
ecdfca5 to
f50fa4f
Compare
github-actions
bot
removed
the
merge_conflict
Starttoaster
pushed a commit
that referenced
this pull request
Jul 31, 2025
* use per-puzzle cost to estimate DEDUP savings, rather than rerunning puzzles * restore SpendBundleAddInfo to have an optional cost. remove unused max_cost parameter from get_deduplication_info() * restore call to make_test_conds() taking cost as int * update test_dedup_by_fee() and fix big in make_bundle_spends_map_and_fee() * review comments * review comments * Addendum to use per-puzzle cost to estimate DEDUP savings (#19816) Addendum to use per-puzzle cost to estimate DEDUP savings. --------- Co-authored-by: Amine Khaldi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
This is an addendum to PR #19811.
Current Behavior:
New Behavior:
Testing Notes: